[FFmpeg-devel] [PATCH] fix crash in ffplay.c #2

Jai Menon jmenon86
Tue Dec 30 13:11:01 CET 2008


On Tue, Dec 30, 2008 at 6:28 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Mon, Dec 29, 2008 at 07:54:26PM -0500, Ronald S. Bultje wrote:
>> Hi,
>> On Mon, Dec 29, 2008 at 7:33 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> > This is certainly not a correct fix ...
>> > And its hard to say how to fix it without any clue about the kind of
>> > file you try to play, or why channels are not set.
>> It's the file provided by Jai in the thread "[FFmpeg-devel] [PATCH]
>> fix crash in realmedia demuxer". The file is a multirate-.rm file,
>> i.e. some tracks only start several MB into the file, I think there's
>> a filesize limit in av_find_stream_info(). anyway, that's practical,
>> in theory there's many reasons why av_find_stream_info() could fail to
>> find stream info for some tracks.
> yes, and ffplay.c should be fixed not to use tracks that lack essential
> information but not to salt the code with
> if(X==0) //it 0 was, me add to crash prevent
> iam really allergic to these kind of "fixes"

This comment also applies to the patch I posted in the thread cited by
Ronald. To clarify,
I explicitly mentioned that the patch couldn't be applied verbatim and
the root cause would have to be
fixed instead. It was just a way of bringing the issue to the
maintainer's notice so to say.
And yes, I do realize these aren't fixes in the true sense :-)



More information about the ffmpeg-devel mailing list