[FFmpeg-devel] [PATCH] Make dither* const

Michael Niedermayer michaelni
Sun Feb 10 01:14:12 CET 2008

On Sat, Feb 09, 2008 at 11:44:30PM +0100, Michael Niedermayer wrote:
> On Sat, Feb 09, 2008 at 11:01:41PM +0100, Reimar D?ffinger wrote:
> > Hello,
> > On Sat, Feb 09, 2008 at 10:52:24PM +0100, Carl Eugen Hoyos wrote:
> > > Was there a reason why dither4 and dither8 in libswscale were not
> > > declared const? Patch attached.
> > 
> > None except that the whole dither stuff if completely broken (not thread
> > safe etc.).
> hum what?

After looking at the code i slowly remember again ;)
Anyway its not really broken or thread unsafe, its just not deterministic
with threads. But thats not a big issue for a +-1 dither ...

If you want to change this, iam pretty sure that theres a register pointing
to some context where the current line dither could be placed.
seems ive half implemented the cleanup and then forgotten about it

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080210/38916b7f/attachment.pgp>

More information about the ffmpeg-devel mailing list