[FFmpeg-devel] [PATCH] [1/??] [3/3] Colorspace negotiation

Vitor Sessak vitor1001
Sun Feb 10 09:37:07 CET 2008


Hi

Michael Niedermayer wrote:
> On Sun, Feb 10, 2008 at 12:30:54AM +0100, Vitor Sessak wrote:
>> Michael Niedermayer wrote:
>>> On Sat, Feb 09, 2008 at 11:07:14PM +0100, Vitor Sessak wrote:
>>>> Hi and thanks for the review,
>>>>
>>>> Michael Niedermayer wrote:
>>>>> On Sat, Feb 09, 2008 at 07:33:04PM +0100, Vitor Sessak wrote:
>>>>>
>> [...]
>>
>>>>> I dont like this, something based on PIX_FMT_NB should work better
>>>> Agree with all of the above. Modified code in 
>>>> http://svn.mplayerhq.hu/soc/libavfilter/formats.c?content-type=text%2Fplain&view=co 
>>>>    av_free(a->refs);
>>>>    av_free(a->formats);
>>>>    av_free(a);
>>>>
>>>>    av_free(b->refs);
>>>>    av_free(b->formats);
>>>>    av_free(b);
>>> these can also be moved into merge_ref()
>>>
>>>
>>> [...]
>>>
>>>>    int idx;
>>>>
>>>>    if((idx = find_ref_index(ref)) >= 0)
>>> int idx= find_ref_index(ref);
>>>
>>> if(idx >= 0)
>>>
>>> and there are more of these
>>>
>>>
>>> [...]
>> Both done (in soc svn).
> 
> looks ok

Is it necessary to copy the whole svn history? If yes, does anyone have 
a script that can do that?

-Vitor





More information about the ffmpeg-devel mailing list