[FFmpeg-devel] [PATCH] RTSP alternate protocol 2-3/3

[Benoit Fouet]

Ronald S. Bultje wrote:
> Hi,
>
> On Feb 11, 2008 3:39 AM, Benoit Fouet <benoit.fouet at purplelabs.com> wrote:
>
>   
>>> -    err = make_setup_request(s, host, port, protocol_mask);
>>> -    if (err)
>>> -        goto fail;
>>> +    do {
>>> +        int protocol = ff_log2_tab[protocol_mask & ~(protocol_mask -
>>>       
>> 1)];
>>     
>>> +
>>> +        err = make_setup_request(s, host, port, protocol);
>>> +        if (err < 0)
>>> +            goto fail;
>>>
>>>       
>> cosmetics, and why have you changed the check ? was there something
>> wrong with it ?
>>     
>
>
> Will fix cosmetics, I missed this one, sorry.
>
> As for the check, a return of 1 now means "protocol not available" (code
> 461), i.e. retry with another protocol. All negative return values imply an
> error and thus we error out. Should I add a comment to make_setup_request()?
>
>   

I don't think so, forget my comment on this.

-- 
Ben
Purple Labs S.A.
www.purplelabs.com