[FFmpeg-devel] [PATCH] use standard macro for ATTR_ALIGN

Diego Biurrun diego
Tue Feb 12 08:59:13 CET 2008


On Tue, Feb 12, 2008 at 01:59:20AM +0100, Michael Niedermayer wrote:
> On Tue, Feb 12, 2008 at 12:32:57AM +0100, Diego Biurrun wrote:
> > libavcodec/i386/idct_mmx.c duplicates a somewhat simplified version of
> > DECLARE_ALIGNED as ATTR_ALIGN.
> > 
> > Here is a patch to replace it with DECLARE_ALIGNED.  OK to apply?
> 
> idct_mmx.c is from libmpeg2 and i see no sense in making future merges
> from or to code from libmpeg2 harder.
> 
> Thus iam against ALL cosmetic changes to it, that includes the ones done
> already.

Don't hold your breath, libmpeg2 has been orphaned for years...

I would treat it like any other file in FFmpeg, but it's your
decision...

> -- 
> I wish the Xiph folks would stop pretending they've got something they
> do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd

:)

Diego




More information about the ffmpeg-devel mailing list