[FFmpeg-devel] [PATCH] remove MSVC cruft

Michael Niedermayer michaelni
Tue Feb 12 17:45:56 CET 2008


On Tue, Feb 12, 2008 at 05:19:28PM +0100, Reimar D?ffinger wrote:
> Hello,
> On Tue, Feb 12, 2008 at 05:12:07PM +0100, Michael Niedermayer wrote:
> > On Tue, Feb 12, 2008 at 04:39:24PM +0100, Reimar D?ffinger wrote:
> > > working code > broken at compile-time >>> broken at runtime.
> > 
> > you forget:
> > working > broken
> > 
> > and a #error in the default case _BREAKS_ ALL non GNU compilers, ffmpeg
> > would no longer need just ISO C + POSIX but GNU
> 
> Yes, but your suggestion would/could land at "broken at runtime" with
> some compilers.

I prefer broken with some compiler over broken with all compilers

I dont understand why you want a #error in the _default_ path?
If there was a HAVE_ASM or so that could be used to choose between #error
and nothing ...


> And because one is maybe more likely but just > vs. >>> #error wins for
> me.
> But the discussion about this has already wasted more time than it

I dont consider flames wasted time :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080212/440f225d/attachment.pgp>



More information about the ffmpeg-devel mailing list