[FFmpeg-devel] [PATCH] remove MSVC cruft

Michael Niedermayer michaelni
Tue Feb 12 19:15:22 CET 2008


On Tue, Feb 12, 2008 at 06:55:16PM +0100, Reimar D?ffinger wrote:
> Hello,
> On Tue, Feb 12, 2008 at 05:45:56PM +0100, Michael Niedermayer wrote:
> > On Tue, Feb 12, 2008 at 05:19:28PM +0100, Reimar D?ffinger wrote:
> > > On Tue, Feb 12, 2008 at 05:12:07PM +0100, Michael Niedermayer wrote:
> > > > On Tue, Feb 12, 2008 at 04:39:24PM +0100, Reimar D?ffinger wrote:
> > > > > working code > broken at compile-time >>> broken at runtime.
> > > > 
> > > > you forget:
> > > > working > broken
> > > > 
> > > > and a #error in the default case _BREAKS_ ALL non GNU compilers, ffmpeg
> > > > would no longer need just ISO C + POSIX but GNU
> > > 
> > > Yes, but your suggestion would/could land at "broken at runtime" with
> > > some compilers.
> > 
> > I prefer broken with some compiler over broken with all compilers
> > 
> > I dont understand why you want a #error in the _default_ path?
> 
> To move the potential failure from runtime to compiletime.

Its a potential failure -> certain failure
And this is not about fragile code possibly failing at runtime. It is
about perfectly solid and conformant ISO C code guranteedly working at
runtime which is hit by this.


> It's two seconds for anyone to fix who knows what they are doing.

Why should a user of a plain ISO C (no asm) compiler have to fix anything
when compiling a program which is supposedly ISO C compared to GNU C?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080212/1ecd03a0/attachment.pgp>



More information about the ffmpeg-devel mailing list