[FFmpeg-devel] Patch: avoid "void * " in pointer calculate

Måns Rullgård mans
Thu Feb 14 01:33:25 CET 2008


mvplayer <ffmpeg at gmail.com> writes:

> On Feb 14, 2008 3:00 AM, Reimar D?ffinger <
> Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
>
>> On Wed, Feb 13, 2008 at 01:46:03PM -0500, Rich Felker wrote:
>> > On Wed, Feb 13, 2008 at 09:29:46PM +0800, mvplayer wrote:
>> > >      /* let's disallow possible ambiguous cases */
>> > > @@ -105,9 +106,9 @@
>> > >      //FIXME this isn't aligned correctly, though it probably isn't
>> needed
>> > >      if(!ptr) return av_malloc(size);
>> > >      diff= ((char*)ptr)[-1];
>> > > -    return realloc(ptr - diff, size + diff) + diff;
>> > > +    return (char*)realloc(ptr - diff, size + diff) + diff;
>> >
>> > This is absolute nonsense. C is not C++.
>>
>> This is about void*-arithmetic...
>
> No! it is + arithmetic

Easy there, he's agreeing with you.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list