[FFmpeg-devel] [PATCH] Fix for lowres decoding support on ARM

Michael Niedermayer michaelni
Sun Feb 17 00:12:57 CET 2008


On Sat, Feb 16, 2008 at 07:36:41PM +0200, Siarhei Siamashka wrote:
> On 27 January 2008, Michael Niedermayer wrote:
> > On Sun, Jan 27, 2008 at 02:09:21AM +0200, Siarhei Siamashka wrote:
> > > On 27 January 2008, Michael Niedermayer wrote:
> > > > mixes functional and cosmetic changes -> split it in 2 patches please
> > > > [...]
> > >
> > > Done. Patch was split into two parts, the second part fixes indentation
> > > problem that gets introduced by the first one.
> >
> > looks ok
> 
> Thank you.
> 
> > also feel free to send patches to fix the other archs
> 
> I have no way to test lowres stuff on other archs, maybe it would be a 
> better idea to just ping all the maintainers of the architectures which 
> are suspected to have this bug too?

You could try but chances are simply fixing the code blindly might be less
work.


> 
> Anyway, what about adding a test to the regression tests set which
> would check lowres decoding?

patch welcome


> 
> Also I wonder if ffmpeg standard regression tests are supposed to help with
> identifying problems in cpu-specific optimizations (ex. IDCT)?

If theres binary identical C code and the optims are used, then the tests
would on a specific CPU help.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080217/38559b5d/attachment.pgp>



More information about the ffmpeg-devel mailing list