[FFmpeg-devel] [PATCH] Fix ffmpeg crash on G3 based computers introduced with revision 10637

Patrice Bensoussan patrice.bensoussan
Tue Feb 19 00:53:49 CET 2008


On 18 Feb 2008, at 22:12, Patrice Bensoussan wrote:

>
> On 18 Feb 2008, at 21:38, Guillaume POIRIER wrote:
>
>> Hello,
>>
>> On Feb 16, 2008 12:47 AM, Alexander Strange <astrange at ithinksw.com>
>> wrote:
>>>
>>> On Feb 15, 2008, at 6:27 PM, Patrice Bensoussan wrote:
>>>
>>>>
>>>> On 15 Feb 2008, at 21:33, Guillaume Poirier wrote:
>>>>
>>>>> I'd prefer the attached patch.
>>>>>
>>>>> Please have a look at it, and test it.
>>>>
>>>> I can't test it as I only have an intel based Mac now, but patch
>>>> looks
>>>> wrong... (missing not in front of has_altivec()). Otherwise, I am  
>>>> ok
>>>> with it...
>>>
>>> mm_flags & MM_ALTIVEC has already been set, you don't need another
>>> check.
>>>
>>> Also, has_altivec() shouldn't be a global symbol without a prefix...
>>
>> Right. Patrice, I discarded your patch and applied Alexander's
>> instead.
>
> OK... stupid question then... where is mm_flags initialized? Can't
> seem to find it...?

Never mind... I finally found it in dsputil_ppc.c





More information about the ffmpeg-devel mailing list