[FFmpeg-devel] [PATCH] Clean up lib* version definitions

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Wed, Feb 20, 2008 at 01:23:40AM +0000, M?ns Rullg?rd wrote:
>> "Ivan Kalvachev" <ikalvachev at gmail.com> writes:
>> 
>> > Anyway.
>> > Congratulations, your commit broke MPlayer, most probably other
>> > applications too.
>> >
>> > vf_pp.c uses the header postprocess.h . In your patch you define the
>> > version using the new system.
>> >
>> > And here is the problem, the macros that calculates  the integer
>> > version is defined in avutil.h, but avutil.h is not included into the
>> > .c file ( as .c file doesn't use anything from avutil). The library
>> > prostprocess.h header file also doesn't include the avutil.h. The
>> > result , obscure compilation error.
>> 
>> Fixed.
>
> Time to have Mike incorporate 'make checkheaders' into FATE?

Unfortunately checkheaders isn't totally accurate.  Even before my
change, postprocess.h relied on avutil.h for some macros.  However,
you'd only notice if you used certain macros defined in postprocess.h.

-- 
M?ns Rullg?rd
mans at mansr.com