[FFmpeg-devel] [PATCH] more riff id's to support stream copy

[Måns Rullgård]

Benjamin Larsson <banan at ludd.ltu.se> writes:

> $topic
>
> MvH
> Benjamin Larsson
> Index: libavcodec/avcodec.h
> ===================================================================
> --- libavcodec/avcodec.h	(revision 12180)
> +++ libavcodec/avcodec.h	(working copy)
> @@ -276,6 +276,8 @@
>      CODEC_ID_NELLYMOSER,
>      CODEC_ID_MUSEPACK8,
>      CODEC_ID_SPEEX,
> +    CODEC_ID_WMAVOICE,
> +    CODEC_ID_WMAPRO,

Minor version bump?

>      /* subtitle codecs */
>      CODEC_ID_DVD_SUBTITLE= 0x17000,
> Index: libavformat/riff.c
> ===================================================================
> --- libavformat/riff.c	(revision 12180)
> +++ libavformat/riff.c	(working copy)
> @@ -177,6 +177,7 @@
>  };
>  
>  const AVCodecTag codec_wav_tags[] = {
> +    { CODEC_ID_WMAVOICE, 0xA },
>      { CODEC_ID_MP2, 0x50 },
>      { CODEC_ID_MP3, 0x55 },
>      { CODEC_ID_AC3, 0x2000 },
> @@ -195,6 +196,7 @@
>      { CODEC_ID_ADPCM_IMA_DK3, 0x62 },  /* rogue format number */
>      { CODEC_ID_WMAV1, 0x160 },
>      { CODEC_ID_WMAV2, 0x161 },
> +    { CODEC_ID_WMAPRO, 0x162 },
>      { CODEC_ID_AAC, 0x706d },
>      { CODEC_ID_AAC, 0xff },
>      { CODEC_ID_VORBIS, ('V'<<8)+'o' }, //HACK/FIXME, does vorbis in WAV/AVI have an (in)official id?

Unrelated to this patch, that array could use a some vertical
alignment and sorting.

Patch seems fine to me, apart from the above comments.

-- 
M?ns Rullg?rd
mans at mansr.com