[FFmpeg-devel] [PATCH] fix memory leaks in vp3 decoder

Michael Niedermayer michaelni
Sun Feb 24 15:37:22 CET 2008


On Sat, Feb 23, 2008 at 06:28:42PM +0000, Mans Rullgard wrote:
> ---
>  libavcodec/vp3.c |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
> 
> diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c
> index 2beb93f..eade1eb 100644
> --- a/libavcodec/vp3.c
> +++ b/libavcodec/vp3.c
> @@ -2313,7 +2313,9 @@ if (!s->keyframe) {
>  static int vp3_decode_end(AVCodecContext *avctx)
>  {
>      Vp3DecodeContext *s = avctx->priv_data;
> +    int i;
>  
> +    av_free(s->superblock_coding);

I think you should just commit such fixes to vp3.c, as it seems mike is
to busy/lazy to review patches to it, or at least ive not seen him do
it lately. (or i need to run memtest /dev/brain ...)

Maybe we should search for a co-maintainer for vp3.c ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080224/db5605e5/attachment.pgp>



More information about the ffmpeg-devel mailing list