[FFmpeg-devel] [PATCH] ACT demuxer

Reimar Döffinger Reimar.Doeffinger
Sun Feb 24 20:45:00 CET 2008


Hello,
On Sun, Feb 24, 2008 at 08:14:50PM +0100, Michael Niedermayer wrote:
> > > and
> > > av_set_pts_info(st, 64, st->codec->frame_size, st->codec->sample_rate);
> > [...]
> > > > +    st->duration=(1000*(min*60+sec)+msec)/st->time_base.num;
> > 
> > This brings up another thing... I do not mind much, but is this better
> > like this or would it be better to always do
> > av_set_pts_info(st, 64, 1, 1000);
> > 
> > and instead set pkt->duration to either 10 or 20?
> 
> ohhh well ...
> time for bikeshed wars :)
> 
> of course it should be 
> av_set_pts_info(st, 64, 1, 100);
> and
> av_set_pts_info(st, 64, 1, 50);
> with duration=1;
> :)

Well, the reason is only that the file seems to specify duration in
millisecond precision for some reason, it could have been that it is for
some good reason and players would be supposed to maybe not play some of
the samples from the last packet.
Ok, ok I know, really unlikely...




More information about the ffmpeg-devel mailing list