[FFmpeg-devel] [PATCH] add uuid box to MP4 to make h.264 play on iPod

[Michael Niedermayer]

On Sun, Feb 24, 2008 at 07:38:11PM +0000, Mark Himsley wrote:
> Michael Niedermayer wrote:
>> On Sun, Feb 24, 2008 at 04:41:26PM +0000, Mark Himsley wrote:
>>> Michael Niedermayer wrote:
>>>> On Sat, Feb 23, 2008 at 12:14:43PM +0000, Mark Himsley wrote:
>>>>   
>>>>> -    else if(track->enc->codec_id == CODEC_ID_H264)
>>>>> +    else if(track->enc->codec_id == CODEC_ID_H264) {
>>>>>          mov_write_avcc_tag(pb, track);
>>>>> +        if(track->mode == MODE_IPOD)
>>>>> +            mov_write_uuid_tag_ipod(pb);
>>>>> +    }
>>>>>     
>>>> Why is this h.264 specific?
>>>>   
>>> Because, as I understand it, the uuid tag is only required by Apple for 
>>> H.264 material.
>> Remove the h264 check please, unless it breaks other files on the ipod OR
>> apples own tools omit it as well.
>
> Apple's own tools omit the uuid tag unless they are outputting H.264. i.e.
>
> * Apple QuickTime Pro does NOT output the uuid tag with MPEG 4 part 2 video 
> in an MP4 container.
>
> * Apple QuickTime Pro DOES output the uuid tab with MPEG4 part 10 video in 
> an MP4 container.
>
>
>> doxygen compatible comments please
>
> I'm trying to :-)

patch looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080229/eb40ddc1/attachment.pgp>