[FFmpeg-devel] [PATCH] socklen_t definition

[Rich Felker]

On Tue, Jan 01, 2008 at 11:00:14AM +0000, M?ns Rullg?rd wrote:
> Rich Felker <dalias at aerifal.cx> writes:
> 
> > On Mon, Dec 31, 2007 at 11:15:39AM +0100, Diego Biurrun wrote:
> >> > --- configure	(revision 11358)
> >> > +++ configure	(working copy)
> >> > @@ -551,6 +551,23 @@
> >> >  
> >> > +check_type(){
> >> > +    log check_type "$@"
> >> > +    headers=$1
> >> > +    type=$2
> >> > +    shift 2
> >> > +    disable $type
> >> > +    incs=""
> >> > +    for hdr in $headers; do
> >> > +        incs="$incs
> >> > +#include <$hdr>"
> >> > +    done
> >> > +    check_cc "$@" <<EOF && enable $type
> >> > +$incs
> >> > +$type v;
> >> > +EOF
> >> > +}
> >> 
> >> Ummm, $headers only ever contains one entry, you just assigned $1 to
> >> it, so what's the point of looping over its content?
> >
> > check_type "foo.h bar.h baz.h" faz_t
> 
> That won't work with the code as-is, since $1 isn't inside quotes.

Word splitting and pathname expansion are not performed on RHS of
assignments in bourne shell. foo="$bar" is always useless; foo=$bar is
just as good.

Rich