[FFmpeg-devel] [PATCH] Realmedia / RTSP (RDT)

[Luca Abeni]

Hi Diego,

Diego Biurrun wrote:
[...]
>> I do not know how the dependencies between muxers and demuxers are 
>> organised, but... This looks very funny.
>> As far as I know, the dynamic payload handlers are used for receiving 
>> RTP traffic, not for sending it... So, I guess this should be
>> #ifdef CONFIG_RTSP_DEMUXER
>>        av_register_rtp_dynamic_payload_handlers();
>> #endif
> 
> Test and commit the fix then :)

Well, as I said I do not know how dependencies are organised, so my 
patch can be wrong... I prefer to post it here for some review instead 
of directly committing it.
Anyway, I had a look at these dependencies, and I now understand why the 
rtsp demuxer currently depends on the RTP muxer: this dependency works 
in practice, but looks strange from the logical point of view.
The attached rtp_dependencies.diff patch seems to work well, and I think 
that the dependencies now look more logical. What's your opinion on it?

After applying the patch, there still are some strange dependencies (for 
example, the RTP muxer depend on the TS demuxer, rtp_h264.c is compiled 
when the RTP muxer is enabled, etc...), but they can be removed with a 
second patch (for example, by adding some "#ifdef"s as in the attached 
rtp_mux_demux.diff patch).


			Thanks,
				Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtp_dependencies.diff
Type: text/x-diff
Size: 2024 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080102/af4bc1ab/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtp_mux_demux.diff
Type: text/x-diff
Size: 2642 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080102/af4bc1ab/attachment-0001.diff>