[FFmpeg-devel] libbrokenos

[Dave Yeo]

On 01/04/08 05:02 am, Luca Abeni wrote:
> Hi Dave,
> 
> first of all, thanks for testing, and for your feedback.

Hi Luca, likewise thanks for working on this,

> 
> Dave Yeo wrote:
> [...]
>> Well here is the complete patch for the changes for libbrokenos to 
>> compile here.
> Uhm... It looks like I did not integrate your previous feedback 
> correctly. Sorry about that.
> BTW, which compiler and libc are used on OS/2? Is it possible to build a 
> cross-compiler using them? It would allow me to test OS/2 compilation 
> before posting the new libbrokenos version...

We are using GCC 3.3.5 and klibc (http://svn.netlabs.org/libc). The libc 
is mostly based on FreeBSD with the stack being an Aix port. Unluckily 
there is no cross compiler available.

> 
>> Also got a parse error in getnameinfo so I looked up the freebsd 
>> manpage 
>> (http://www.freebsd.org/cgi/man.cgi?query=getnameinfo&sektion=3&apropos=0&manpath=FreeBSD+6.2-RELEASE) 
>>
>> and changed the DWORD to size_t.
> Ok. I got it from some windows headers, and I did not think about 
> DWORD... Sorry.
> 
>> Unluckily compiling FFmpeg is another matter, due to using the same 
>> header names as the system uses there are conflicts and I get various 
>> errors depending on how I arrange things.
> What happens if you just remove from libbrokenos the headers that are 
> already in your include directory?

The build dies in libavformat/rtsp.c due to socklen_t not being defined. 
Also to build libbrokenos I had to remove the empty sys/socket.h

> 
>> I think that any headers included with libbrokenos should have unique names.
> Yes, this is something I forgot to mention: if a header is already 
> provided by your compiler/libc, it should not be provided by libbrokenos 
> (so it should be removed). I hope this will work, but I am not sure... 
> When libbrokenos will have a configure script, it will take care of 
> automatically selecting the proper headers based on the ones provided by 
> the system.
> 
> [...]
>> diff -ru libbrokenos/lseek.c libbrokenos.os2/lseek.c
>> --- libbrokenos/lseek.c	Wed Dec 26 14:08:16 2007
>> +++ libbrokenos.os2/lseek.c	Thu Jan  3 14:56:00 2008
>> @@ -1,4 +1,5 @@
>>  #include "network.h"
>> +#include "os_config.h"
> 
> Is this really needed? network.h should include some headers that 
> already include os_config.h.

Actually no, it is not needed.

> 
> I am integrating your other changes, and hopefully this time I'll get 
> them right :)
> 
> 
> 			Thanks,
> 				Luca

Dave