[FFmpeg-devel] [Patch] Behaviour of liba52 decoder

[Ivo]

On Thursday 10 January 2008 13:44, Ivo wrote:
> On Thursday 10 January 2008 13:24, Thorsten Jordan wrote:
> > Michael Niedermayer schrieb:
> > > Hi
> > >
> > >> any comments?
> > >
> > > a52_decode_frame() looks buggy yes ...
> > > i suggest you rewrite it ...
> >
> > ok, here is try 1 of a patch.
> > as this is my first longer patch, please be patient with me ;)
> > i hope indentation is correct.
>
> I have no knowledge of how to interface to liba52, but by just looking at
> the patch I notice a lot of lines being only indented differently. Those
> should not change in the initial patch. They can be reindented for
> cosmetic reasons afterwards. e.g.
>
> -while (foo) {
> -    something;
> -    something_else;
> -    and_something_else;
>  something;
>  something_else;
>  and_something_else;
> -}

Forgot the +'s in the what's-bad-example:

-while (foo) {
-    something;
-    something_else;
-    and_something_else;
+something;
+something_else;
+and_something_else;
-}

That's what I meant offcourse. 

--Ivo