[FFmpeg-devel] [PATCH] Automatically generate ac3enc_data.h

[Aurelien Jacobs]

Michael Niedermayer wrote:

> On Sat, Jan 12, 2008 at 05:31:00PM +0100, Aurelien Jacobs wrote:
> > Diego 'Flameeyes' Petten? wrote:
> > 
> > > 
> > > It's not the nicest thing out there, but it should work...
> > > 
> > > [...]
> > > 
> > > +%-gentables: %_tables.c
> > > +	$(CC) $(CFLAGS) -DGENTABLES -o $@ $^ $(EXTRALIBS)
> > 
> > $(CC) is the TARGET compiler. You can't use it to compile binary
> > that must be run on HOST. (you cross-compiling...)
> > 
> 
> > Now that I think about it, it could be better to keep the
> > ac3enc_data.h file in the repository, 
> 
> hmm, i cant explain it but i dont like this idea

Having an explanation would be nice, but well...

> > and have a `make gentable` target which would
> > force tables re-building.
> > That way, normal compilation would be exactly the same as now (no
> > need for a different HOST and TARGET compiler, etc...), and tables
> > can still be re-built automatically when a developer want to change
> > a table (in this specific situation, you may assume that
> > HOST==TARGET, and thus, don't care about cross-compilation).
> 
> if theres no host compiler then the user will have to use the runtime
> generated tables

Indeed. As long as runtime generated tables is the default there won't
be any visible change to basic users. So I guess it's acceptable to
depend on HOSTCC for those people who configure with hardcoded tables.

Aurel