[FFmpeg-devel] [PATCH] Bunch of accumulated patches...

[Rich Felker]

On Mon, Jan 14, 2008 at 11:41:43PM +0000, M?ns Rullg?rd wrote:
> Rich Felker <dalias at aerifal.cx> writes:
> 
> > On Mon, Jan 14, 2008 at 11:47:49PM +0100, Michael Niedermayer wrote:
> >> On Mon, Jan 14, 2008 at 05:54:19PM -0500, Rich Felker wrote:
> >> > On Mon, Jan 14, 2008 at 11:31:37PM +0100, Michael Niedermayer wrote:
> >> > > there are really several seperate things here
> >> > > 1. non posix systems -> work on libos (see the ML) or fix your system
> >> > > 2. error cases which cant be represented well with posix E* -> send
> >> > >    patches which define custom E* for us, note, this also needs a
> >> > >    configure check so that they dont interfere with any posix E*
> >> > 
> >> > E* is reserved if errno.h is included. #defining anything beginning
> >> > with E is a very bad idea.
> >> 
> >> then AV_E* or just the AVERROR_* still we must ensure the value
> >> doesnt collide with any of the standard E*
> >
> > Then AVERROR_ values should be long long with bits higher than 32bit
> > set.. IMO it's a mistake to try to mix E* values with one's own error
> > codes, but this is a reasonably safe method that could probably be
> > used..
> 
> FWIW, the standard requires E* to be positive integer constant
> expressions with type int.

Ah yeah I forgot the positivity requirement. So negative values makes
it easy to define your own errors.

Rich