[FFmpeg-devel] [PATCH] Bunch of accumulated patches...

Sigbjørn Skjæret cisc
Wed Jan 16 07:06:43 CET 2008

>> I did actually notice, the only problem is that it uses av_tree_node_size to
>> accomplish this, which kind of brings us full circle .. having the caller
>> allocating something your code is solely responsible for manipulating is a bad
>> idea on several levels.
> And that gets us back to my question, if you know a equivalently effective
> and simple alternative.

Well, I do, but you do not approve, so that gets us nowhere.

> If not the design is optimal (compared to all alternatives proposed) and its
> your philosophical view which seems faulty.

Not necessarily, quite often you'll find that the cleanest way is not the
fastest most convenient way (you'll even find the fastest most convenient way
often referred to as a hack by those who dare comment their work. ;) ).

> And besides, yes i disagree, theres nothing wrong with the caller doing
> allocation of needed (possibly temporary) space.

Fine, then there's no point for me to pursue this further.

Anyway, let's talk about another possible patch; I found a few uses of puts(),
I'm guessing they are not supposed to be there, and should perhaps be exchanged
in favour of av_log() (or possibly just removed), however there's no context
available, so it'd have to be NULL, would that be an acceptable patch?


More information about the ffmpeg-devel mailing list