[FFmpeg-devel] [PATCH] fix libavcodec test programs

[Diego Biurrun]

On Wed, Jan 23, 2008 at 01:12:04AM +0100, Michael Niedermayer wrote:
> On Wed, Jan 23, 2008 at 12:53:23AM +0100, Diego Biurrun wrote:
> > Here is a patch to make the test programs in rangecoder.c and cabac.c
> > compile again.  If it's OK I would commit in several steps.
> 
> ok

Applied.

> > h264.c contains another test program, but I fear it is beyond my
> > immediate ability for repair.  It uses the functions h264_diff_dct_c
> > and encode_nal which no longer exist.  Is it worth keeping or should it
> > just be removed?
> 
> NOTHING should be removed without a very good reason, "not working" is never
> a good reason!

Being in a state of disrepair without any hope of repair in the
foreseeable future can be such a reason.

Anyway, here is a patch that disables all problematic parts and "fixes"
compilation.  I searched for the missing functions, encode_nal() was
removed in r7228, h264_diff_dct_c in r7244, both commits by takis.

Shall I commit that?

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: h264_test.diff
Type: text/x-diff
Size: 870 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080123/cfafb69c/attachment.diff>