[FFmpeg-devel] [PATCH] fix libavcodec test programs

[Michael Niedermayer]

On Wed, Jan 23, 2008 at 01:05:49PM +0100, Panagiotis Issaris wrote:
> Diego Biurrun schreef:
> > On Wed, Jan 23, 2008 at 01:12:04AM +0100, Michael Niedermayer wrote:
> >> On Wed, Jan 23, 2008 at 12:53:23AM +0100, Diego Biurrun wrote:
> >>> Here is a patch to make the test programs in rangecoder.c and cabac.c
> >>> compile again.  If it's OK I would commit in several steps.
> >> ok
> > 
> > Applied.
> > 
> >>> h264.c contains another test program, but I fear it is beyond my
> >>> immediate ability for repair.  It uses the functions h264_diff_dct_c
> >>> and encode_nal which no longer exist.  Is it worth keeping or should it
> >>> just be removed?
> >> NOTHING should be removed without a very good reason, "not working" is never
> >> a good reason!
> > 
> > Being in a state of disrepair without any hope of repair in the
> > foreseeable future can be such a reason.

You do NOT know if it is in a "state of disrepair without any hope of repair
in the foreseeable future"
Hardly anyone except the author is in a position to judge that without major
effort ...

having some #if 0 function at the end of a file does no harm, just leave them
The time of the maintainer can be spend better than to review such removials


> > 
> > Anyway, here is a patch that disables all problematic parts and "fixes"
> > compilation.  I searched for the missing functions, encode_nal() was
> > removed in r7228, h264_diff_dct_c in r7244, both commits by takis.
> 
> Before my commit removing it, it was "#if 0"-ed out. And the code in 
> encode_nal() was reused in h264enc.c, in h264_write_nal_unit().

a nice example of why removials are bad ...
first half the code disappears, then the other half is in a "state of
disrepair without any hope of repair in the foreseeable future"

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080123/642a9d56/attachment.pgp>