[FFmpeg-devel] [PATCH] fix libavcodec test programs

[Diego Biurrun]

On Wed, Jan 23, 2008 at 03:45:18PM +0100, Michael Niedermayer wrote:
> On Wed, Jan 23, 2008 at 01:05:49PM +0100, Panagiotis Issaris wrote:
> > Diego Biurrun schreef:
> > > On Wed, Jan 23, 2008 at 01:12:04AM +0100, Michael Niedermayer wrote:
> > >> On Wed, Jan 23, 2008 at 12:53:23AM +0100, Diego Biurrun wrote:
> > >>> Here is a patch to make the test programs in rangecoder.c and cabac.c
> > >>> compile again.  If it's OK I would commit in several steps.
> > >> ok
> > > 
> > > Applied.
> > > 
> > >>> h264.c contains another test program, but I fear it is beyond my
> > >>> immediate ability for repair.  It uses the functions h264_diff_dct_c
> > >>> and encode_nal which no longer exist.  Is it worth keeping or should it
> > >>> just be removed?
> > >> NOTHING should be removed without a very good reason, "not working" is never
> > >> a good reason!
> > > 
> > > Being in a state of disrepair without any hope of repair in the
> > > foreseeable future can be such a reason.
> 
> You do NOT know if it is in a "state of disrepair without any hope of repair
> in the foreseeable future"
> Hardly anyone except the author is in a position to judge that without major
> effort ...

I see no conflict between what I wrote and what you say...

Diego