[FFmpeg-devel] [PATCH] libavformat/mov.c memleak bugfix

Måns Rullgård mans
Fri Jan 25 21:18:01 CET 2008


"Zdenek Kabelac" <zdenek.kabelac at gmail.com> writes:

> 2008/1/25, Baptiste Coudurier <baptiste.coudurier at smartjog.com>:
>> Hi,
>>
>> Zdenek Kabelac wrote:
>> > Hi
>> >
>> > Here is a memleak patch for the allocation of MOVStreamContext in the
>> > mov_read_trak.
>> >
>> > Also I believe it is save to check the sc pointer prior doing
>> > dereference - thought I've not checked very deep if this combination
>> > will never happen.
>> >
>>
>> I think the free can be done in a generic way in av_close_input_stream,
>> where st is freed.
>
> But I think you cannot easily guarantee that priv_data will be always
> the allocated pointer - it might be some integer value casted to void*
> - or some other crazy type ??

Only if you wrote the code.  Fortunately for us, you didn't.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list