[FFmpeg-devel] [RFC] replace some static with asm_visibility or so

Benoit Fouet benoit.fouet
Wed Jan 30 09:11:22 CET 2008


Balatoni Denes wrote:
> Hi!
> Tuesday 29 January 2008 19:10-kor Ivan Kalvachev ezt ?rta:
>> About the grammar. There is nothing worse than making your best
>> efforts to do something and then been ridiculed over the result.
> Also well said.

this is not true...
while you're at it, why not saying that you're being ridiculed because
of code reviews ?
to me, this is the same thing: there are rules you have to follow, if
you don't, people try to correct your mistakes, it's as simple as that.

> ps: there is one thing about the high coding standards - I understand the 
> need, however it would be great if in the first reply (or at least soon) it 
> was made clear what is the needed minimum for svn acceptance.

could you be clearer ?
isn't the 'coding rules' section enough ?

>  I mean it 
> sometimes seems an endless process, when every review brings up new and new 
> showstopper issues - I think it would be less frustrating to the contributor 
> if all showstopper issues were made clear right from the start, it's also 
> good for planning (for the contributor and everybody), to see clearly early 
> in the process what needs to be fixed. just my two cents.

Purple Labs S.A.

More information about the ffmpeg-devel mailing list