[FFmpeg-devel] [PATCH] Add versioning information to dlls

[Måns Rullgård]

Diego Biurrun wrote:
> On Tue, Jul 01, 2008 at 11:30:33AM +0100, M?ns Rullg?rd wrote:
>>
>> Diego Biurrun wrote:
>> > On Mon, Jun 30, 2008 at 11:35:50AM -0400, Jeremy Kolb wrote:
>> >> M?ns Rullg?rd wrote:
>> >>> version.h is now correctly created from subdirs, and dependencies are
>> >>> correct even if it's missing.
>> >>
>> >> This patch seems to work correctly on my machine both in subdirectories
>> >> and from the top-level tree.
>> >
>> > Does it also work if you build out-of-tree?
>> >
>> >> --- configure	(revision 14033)
>> >> +++ configure	(working copy)
>> >> @@ -970,6 +970,7 @@
>> >>
>> >>  # gcc stupidly only outputs the basename of targets with -MM
>> >>  DEPEND_CMD='$(CC) $(CFLAGS) -MM -MG $< | sed -e "/^\#.*/d" -e
>> >> "1s,^,$(@D)/," -e
>> >> "s,\\([[:space:]]\\)\\(version\\.h\\),\\1\$$(BUILD_ROOT_REL)/\\2," -e
>> >> "s/\(.*\)\.o/\1.d &/"'
>> >> +DEPEND_CMDRC='$(CC) $(CFLAGS) -MM -MG -DRC_INVOKED -xc-header $< | sed
>> -e
>> >> "/^\#.*/d" -e "1s,^,$(@D)/,"'
>> >
>> > Why are you skipping the rest of the sed commands?  What is the output
>> > or DEPEND_CMDRC?
>>
>> Rather than another variable, just add the extra flags in the make rule.
>
> How?

%.d: %.rc CFLAGS += -DRC_INVOKED -xc-header
	$(DEPEND_CMD) > $@

This construct is already used elsewhere in the makefiles.

-- 
M?ns Rullg?rd
mans at mansr.com