[FFmpeg-devel] [PATCH] libavdevice/x11grab.c XFixesGetCursorImage support

Michael Niedermayer michaelni
Thu Jul 3 14:23:28 CEST 2008

On Wed, Jul 02, 2008 at 01:22:26PM +0200, Roxis wrote:
> I made a patch to add real cursor support in x11grab.
> But i'm not a c programmer, patch is far from ideal but works for me.

If you know its not ideal then you can recognize some problems, fix them :)
the return in the middle is the most obvious one ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080703/b5a09b31/attachment.pgp>

More information about the ffmpeg-devel mailing list