[FFmpeg-devel] [PATCH] Document opt.h:av_find_opt()

Stefano Sabatini stefano.sabatini-lala
Fri Jul 4 00:22:05 CEST 2008


On date Thursday 2008-07-03 16:16:15 +0200, Michael Niedermayer encoded:
> On Thu, Jul 03, 2008 at 03:06:31PM +0200, Stefano Sabatini wrote:
[...]
> > > What about s/AVClass.*struct/AVClass/?
> > > 
> > > /**
> > >  * Describes the class of an AVClass context, that is an
> > >  * arbitrary struct of which the first field is a pointer to an
> > >  * AVClass (e.g. AVCodecContext, AVFormatContext etc.).
> > >  */
> > > 
> > >  * @param[in] obj a pointer to an #AVClass or to an #AVClass
> > >  * context
> > 
> > If that's OK (no explicit objections or further comments) I'll commit
> > both modifications (log.h and opt.h) after three days.
> 
> I object
> for exampe to "or" in the description, there are no 2 different things.
> I also object to AVClass.*context
> I do not know what all these AVClass structs contextes and classes are
> supposed to be and if I as a developer working with the code am confused
> by the terminology iam sure a person not used to the stuff will be as
> well.

Hi all, please check again, I'm also OK with this, nonetheless I find
quite useful the AVClass context definition ("a struct whose first
element is a pointer to an AVClass structure").

Nonetheless you have the final decision, and if you don't like it,
then I propose to elimintate that definition from log.h too.

Regards.
-- 
FFmpeg = Free Fast Mastering Purposeless Embarassing God
-------------- next part --------------
A non-text attachment was scrubbed...
Name: document-av-opt-find-02.patch
Type: text/x-diff
Size: 966 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080704/18d23c13/attachment.patch>



More information about the ffmpeg-devel mailing list