[FFmpeg-devel] [PATCH] MLP/TrueHD Decoder - 2nd try

[Ian Caulfield]

2008/7/4 Michael Niedermayer <michaelni at gmx.at>:
> On Fri, Jul 04, 2008 at 01:15:20AM +0100, Ramiro Polla wrote:
>
> [...]
>> /** Read parameters for one of the prediction filters. */
>>
>> static int read_filter_params(MLPDecodeContext *m, GetBitContext *gbp,
>>                               unsigned int channel, unsigned int filter)
>> {
>>     const char fchar = filter ? 'I' : 'F';
>>     int i, order;
>>
>>     // filter is 0 for FIR, 1 for IIR
>>     assert(filter < 2);
>>
>>     order = get_bits(gbp, 4);
>>     if (order > MAX_FILTER_ORDER) {
>>         av_log(m->avctx, AV_LOG_ERROR,
>>                "%cIR filter order %d is greater than maximum %d\n",
>>                fchar, order, MAX_FILTER_ORDER);
>>         return -1;
>>     }
>>     m->filter_order[channel][filter] = order;
>>
>>     if (order > 0) {
>
> is a filter order == 0 even valid ?

A filter order of zero means "don't filter"

Ian