[FFmpeg-devel] C99 or GCC extensions

[Diego Biurrun]

On Sat, Jul 05, 2008 at 09:22:49AM +1000, pross at xvid.org wrote:
> On Fri, Jul 04, 2008 at 10:20:12PM +0200, Guillaume POIRIER wrote:
> > 
> > On Fri, Jul 4, 2008 at 9:48 PM, Axel Holzinger <aholzinger at gmx.de> wrote:
> > >
> > > I.e. #define AVV(x...) {x} instead of #define AVV(...) {__VA_ARGS__}
> > >
> > > I will work on this and send patches.
> > 
> > Don't work on this issue, it's useless.
> > This macro aims at supporting writing Altivec constants with both
> > Motorola (used in Apple version of GCC, and in codewarior, maybe even
> > in XLC) and FSF (used in FSF GCC) syntaxes.
> 
> Coincidently I hit the same problem recently when compiling ffmpeg with
> icc-win32. Patch enclosed.

Hmmmmmm

> --- libavutil/internal.h	(revision 14063)
> +++ libavutil/internal.h	(working copy)
> @@ -50,11 +50,13 @@
>  
> +#ifdef HAVE_ALTIVEC
>  #ifdef HAVE_ALTIVEC_VECTOR_BRACES
>  #define AVV(x...) {x}
>  #else
>  #define AVV(x...) (x)
>  #endif
> +#endif

I don't see what this should help, HAVE_ALTIVEC_VECTOR_BRACES is only
set if configure detects AltiVec.  So in you case it should be undefined
and there should be no problem.  What exactly is happening.

Diego