[FFmpeg-devel] [PATCH] Document opt.h:av_find_opt()
Sun Jul 6 10:18:22 CEST 2008
On date Friday 2008-07-04 01:29:10 +0200, Michael Niedermayer encoded:
> On Fri, Jul 04, 2008 at 12:22:05AM +0200, Stefano Sabatini wrote:
> > On date Thursday 2008-07-03 16:16:15 +0200, Michael Niedermayer encoded:
> > > On Thu, Jul 03, 2008 at 03:06:31PM +0200, Stefano Sabatini wrote:
> > [...]
> > > > > What about s/AVClass.*struct/AVClass/?
> > > > >
> > > > > /**
> > > > > * Describes the class of an AVClass context, that is an
> > > > > * arbitrary struct of which the first field is a pointer to an
> > > > > * AVClass (e.g. AVCodecContext, AVFormatContext etc.).
> > > > > */
> > > > >
> > > > > * @param[in] obj a pointer to an #AVClass or to an #AVClass
> > > > > * context
> > > >
> > > > If that's OK (no explicit objections or further comments) I'll commit
> > > > both modifications (log.h and opt.h) after three days.
> > >
> > > I object
> > > for exampe to "or" in the description, there are no 2 different things.
> > > I also object to AVClass.*context
> > > I do not know what all these AVClass structs contextes and classes are
> > > supposed to be and if I as a developer working with the code am confused
> > > by the terminology iam sure a person not used to the stuff will be as
> > > well.
> > Hi all, please check again, I'm also OK with this, nonetheless I find
> > quite useful the AVClass context definition ("a struct whose first
> > element is a pointer to an AVClass structure").
> > Nonetheless you have the final decision, and if you don't like it,
> > then I propose to elimintate that definition from log.h too.
> patch looks ok
FFmpeg = Fast & Fostering Magic Pitiful Erotic Governor
More information about the ffmpeg-devel