[FFmpeg-devel] C99 or GCC extensions
Fri Jul 11 22:58:01 CEST 2008
On Fri, Jul 11, 2008 at 08:02:28PM +0200, Axel Holzinger wrote:
> Axel Holzinger <aholzinger at gmx.de> writes:
> > "M?ns Rullg?rd" <mans at mansr.com> writes:
> > > It is customary to write "static type" rather than "type
> > static".
> > Will do so.
> > > Lose the backslashes.
> > Ditto.
> > > > #elif defined(CONFIG_FASTDIV)
> > > > # define FASTDIV(a,b)
> > > ((uint32_t)((((uint64_t)a)*ff_inverse[b])>>32))
> > > > #else
> > >
> > > Unrelated to this change, machine-specific code should go into
> > > subdirs, IMHO.
> Okay, didn't get that. Yes it would be better to put the machine-
> specific part into subdirs. But in libavutil there aren't yet any
> subdirs, so we would start doing so. I will study how this is
> done in lavf or lavc, but don't be too impatient, I'm still
> learning :-)
> So here's version two with the promised changes.
Please also post some benchmarks that show that the uses of FASTDIV
didnt become slower. (see START/STOP_TIMER)
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Opposition brings concord. Out of discord comes the fairest harmony.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel