[FFmpeg-devel] [PATCH] scale msadpcm table to fit in int8_t

Reimar Döffinger Reimar.Doeffinger
Sat Jul 12 09:28:55 CEST 2008

On Sat, Jul 12, 2008 at 03:48:38AM +0200, Michael Niedermayer wrote:
> On Fri, Jul 11, 2008 at 06:14:44PM -0700, Mike Melanson wrote:
> > Reimar D?ffinger wrote:
> > > this implements the same change I did to the MPlayer decoder.
> > > Saves only a few bytes though and would probably be slower on an 8-bit
> > > CPU without good shift support (e.g. Atmel AVR) if someone cares...
> > 
> > I guess ADPCM algorithms are not specified to be bit exact? This changes 
> > the output from before. But as long as it sounds right, I can update the 
> > relevant FATE tests. However, you will be responsible for updating the 
> > regression tests (which are presently broken due to this change).
> hmmmmmmmmmm
> i thought it was a bitexact optim just reducing the table sizes
> has reimar maybe missed some use of the tables? :)

Yes, I missed one of the / 256. Regression tests are now working again.

More information about the ffmpeg-devel mailing list