[FFmpeg-devel] [PATCH] fix various bugs in lzw decoder
Sun Jul 13 22:04:56 CEST 2008
On Sun, Jul 13, 2008 at 09:05:56PM +0200, Michael Niedermayer wrote:
> On Sun, Jul 13, 2008 at 08:30:21PM +0200, Reimar D?ffinger wrote:
> > Hello,
> > while working on issue 530 I found a whole load of problems with the
> > various lzw decoders (yes, it is long time to get rid of one of those,
> > but I won't do it ;-) ).
> just took me a few seconds to svn rm one
> If anyone wants the functionality back he can start at the begin of the
> review process with a clean patch, which uses the lzw&gif code from lavc.
I agree, I once wanted to work on all this stuff, but I never got to it,
no idea if I ever will.
> > First, codesize must be _smaller_ than MAXBITS, since otherwise cursize
> > can be larger than MAXBITS and thus a code returned by get_code might
> > result in an access outside e.g. the prefix array.
> > It might be conceptually nicer to change SIZTABLE instead, no idea.
> maybe, anyway patch ok, it can always be changed to make it nicer
More information about the ffmpeg-devel