[FFmpeg-devel] libraries linked with libX11 on GNU/kFreeBSD

[The Wanderer]

Reinhard Tartler wrote:

> M?ns Rullg?rd <mans at mansr.com> writes:
> 
>> Reinhard Tartler wrote:

>>> On GNU/kFreeBSD, -Wl,--as-needed is not used, so VLC fails to
>>> build. Please find below a patch to fix that.
>>>
>>> --- ffmpeg-free-0.svn20080206.orig/configure
>>> +++ ffmpeg-free-0.svn20080206/configure
>>
>> OMG, that's old.
> 
> Yes, but I've chcked that this patch applies to current trunk
> perfectly.

Then it should have been remade with 'svn diff' against the latest
development tree, and submitted in that form.

There are also at least two other ways it didn't comply with the
patch-submission policy...

>>> @@ -1289,6 +1289,9 @@
>>>          SLIB_UNINSTALL_EXTRA_CMD='rm -f
>>>          "$(LIBDIR)"/$(LIBPREF)$(NAME)_dll.a
>>>          "$(LIBDIR)"/$(LIBPREF)$(NAME)_dll.lib'
>>>          vhook="no"
>>>          ;;
>>> +    gnu/kfreebsd)
>>> +        LDLATEFLAGS="-Wl,--as-needed $LDLATEFLAGS"
>>> +        ;;
>>>
>>>      *)
>>>          targetos="${targetos}-UNKNOWN"
>>
>> The use of this flag should depend on the linker, not the OS.  If
>> existing code sets this based on OS, that code is wrong and should
>> be fixed.  Patches adding incorrect code are rejected, regardless
>> of what already exists.
> 
> I see.
> 
> The patch in question here however does not really add code, though.

It doesn't? What is the hunk above, then?

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.