[FFmpeg-devel] [PATCH] Warn about PAFF & Spatial

[Paul Kendall]

On Thursday 17 July 2008 09:31:58 Michael Niedermayer wrote:
> On Wed, Jul 16, 2008 at 01:57:43PM -0700, Serguei Miridonov wrote:
> > On Wednesday 16 July 2008, Serguei Miridonov wrote:
> > > On Wednesday 16 July 2008, Michael Niedermayer wrote:
> > > > On Wed, Jul 16, 2008 at 08:21:02AM -0700, Serguei Miridonov wrote:
> > > > > On Wednesday 16 July 2008, Michael Niedermayer wrote:
> > > > > > On Tue, Jul 15, 2008 at 11:36:35PM -0700, Serguei Miridonov
> > >
> > > wrote:
> > > > > > > While the issue 460 is not resolved, just to avoid log
> > > > > > > flood:
> > > > > > >
> > > > > > > See attachment..
> > > > >
> > > > > [...]
> > > > >
> > > > > > non constant static,
> > > > >
> > > > > Sorry, I don't know what you mean...
> > > >
> > > > I mean if i run
> > > > mplayer *.h264
> > > > then the warning will be printed just once, it should be once per
> > > > file also if i decode 2 h264 files in parallel i want to see 2
> > > > warnings if it applies to both files
> > >
> > > Well, for me, and may be for many other users, it would be enough
> > > to see a warning only once: just to know that ffmpeg does not
> > > support that mode. And this can be implemented very easy by this
> > > patch.
> > >
> > > Another approach is to make it as you suggest. But this, as I
> > > understand, will require to add a variable in file or stream
> > > context structure. If you know how to do that, do ahead. I just
> > > don't feel myself very familiar with ffmpeg and therefore don't
> > > want to add a complexity which, I think, is not necessary.
> > >
> > > May be the best approach is to make the log subsystem to report
> > > some kinds of errors/warnings once using a flag like
> > > AV_LOG_FLAG_ONCE. But this also requires additional complexity in
> > > data structures...
> >
> > So, Michael, what do you suggest? Do you think that log flood with
> > warning after every frame is better than to show the message just
> > once?
>
> I think nasty hacks are worse than a few log messages.
> If the log flood bothers you, find a clean solution or fix the decoder
> so the combination is fully supported or in case its alraedy fully
> supported and the message is wrong provide some evidence for that.
> Or change it to warning instead of error ...
> [...]

Or perhaps, adding the 'once' variable to H264Context is better, and obviously 
choosing a better name?

Cheers,
Paul