[FFmpeg-devel] libraries linked with libX11 on GNU/kFreeBSD

Diego Biurrun diego
Thu Jul 17 11:49:17 CEST 2008

On Thu, Jul 17, 2008 at 07:59:46AM +0200, Reinhard Tartler wrote:
> M?ns Rullg?rd <mans at mansr.com> writes:
> >> Anyway, patch looks OK to me, cleaning up LDLATEFLAGS is outside of the
> >> scope of adding gnu/kfreebsd support.
> >
> > I stand by my rejection of the patch.  The existing code is wrong.  We
> > should fix it properly instead of adding more broken code.
> Okay, no problem. I'll carry then this patch in the debian/ubuntu
> package until the code in question gets replaced upstream then. And to
> be honest, I doubt that someone outside Debian actually cares about
> gnu/kfreebsd.

An even better procedure would be to propose the patch before applying
it to your package and then try to find a clean solution in cooperation
with your upstream (us).  You could then backport such a solution to
your package.

Applying a workaround to your package and proposing it upstream is much
better than applying a workaround and not proposing it, no matter how
hackish the workaround may be.  This way we get notified that there is
a problem and can look for better solutions.

Still, this reminds me a bit of a "shoot first, ask questions later"
attitude ;) - in a perfect world you would choose the first route
instead of the second.


More information about the ffmpeg-devel mailing list