[FFmpeg-devel] [PATCH] make sure initialization happens even after goto fires

Michael Niedermayer michaelni
Thu Jul 17 19:03:43 CEST 2008


On Thu, Jul 17, 2008 at 09:08:40AM -0700, Erik Hovland wrote:
> The goto in ff_h264_find_frame_end() is inside an else clause. The
> initialization for v happens in the if clause elsewhere. That means that
> it is possible for the goto to fire without the initialization of v
> happening. Normally this isn't a problem. But gcc recognizes this and
> throws an internal parse warning. It then has to go through a special
> code branch to take care of this. If the initialization of v always
> happens before either clause this does not happen. The attached patch
> does just that.

Is there any bug in our code?
If not, then what is it that you are trying to fix?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080717/0b85bdeb/attachment.pgp>



More information about the ffmpeg-devel mailing list