[FFmpeg-devel] [PATCH] ffmpeg.c: keep small last frame size

Michael Niedermayer michaelni
Sat Jul 19 16:37:43 CEST 2008

On Sat, Jul 19, 2008 at 10:08:22AM -0400, Justin Ruggles wrote:
> Hi,
> I noticed what I think is an error in a patch I submitted 2 years ago.
> When the audio codec has CODEC_CAP_SMALL_LAST_FRAME, the original frame
> size is being restored after the final encode.  I don't think this is
> right, and would likely mess up the calculation of the final packet
> duration.

encoder -> packet fifo -> muxer

1. encoder encodes last frame (#100)
2. muxer takes frame #59 of the fifo and uses frame_size for something

no, i do not think your patch is correct

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080719/37cdc378/attachment.pgp>

More information about the ffmpeg-devel mailing list