[FFmpeg-devel] [PATCH] simplify mpeg12/8bps pix_fmt set

[Baptiste Coudurier]

Ivan Kalvachev wrote:
> On Sat, Jul 19, 2008 at 6:09 AM, Baptiste Coudurier
> <baptiste.coudurier at smartjog.com> wrote:
>> Hi
>>
>> $subject, did it ever work ?
>>
>> get_format seems to be used/introduced for XVMC, is it still in use ?
> 
> I don't like it.

Humm, what exactly do you not like ?

> First get_format() was not introduced for XvMC, I just took advantage of it.
> 
> Second in 8bps is using it for real, so you remove functionality.

Exporting RGB32 when bps == 24 ? Does it even work and what's the use ?

> Third. While working on xvmc, I found out that there is no function
> that would tell the image properties (pix_fmt, width, height) to the
> video system. As effect it is initialized on get_buffer() or after
> first frame is decoded, sometimes this may cause interesting race
> conditions. e.g. when stream changes resolution.
> It simplifies player a lot if each codec calls get_format() just for
> that purpose. Unfortunately nobody else seems to be interested in
> that.

Well it was agreed that each codec should output their native format, I
think I can understand the need to output uyvy422 instead of yuv422p,
but clearly not rgb32 instead of bgr24.

Besides, in 8bps _and_ in mpeg12, the interest you describe is not
usefull since function is called only during init.

I'll ask my question again, is it used and what's the exact use ? only
for XVMC right ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA