[FFmpeg-devel] [PATCH 1/4] add a generic function to lavc to log messages about missing features.

[Justin Ruggles]

Michael Niedermayer wrote:
> On Sat, Jul 19, 2008 at 07:50:25PM -0400, justin.ruggles at gmail.com wrote:
>> ---
>>  libavcodec/avcodec.h |   11 +++++++++++
>>  libavcodec/utils.c   |   12 ++++++++++++
>>  2 files changed, 23 insertions(+), 0 deletions(-)
>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>> index 4942ab1..33a1258 100644
> 
> It would be very nice if you could get your git-send-mail to include the
> commit message in the mail. (this applies to other people as well)

I haven't been able to do this, but I'll keep trying.  If I can't figure
it out before I need to send another patch set, I'll manually edit the
patches before using git-send-email.

>> --- a/libavcodec/avcodec.h
>> +++ b/libavcodec/avcodec.h
>> @@ -3003,6 +3003,17 @@ int av_parse_video_frame_size(int *width_ptr, int *height_ptr, const char *str);
>>   */
>>  int av_parse_video_frame_rate(AVRational *frame_rate, const char *str);
>>  
>> +/**
>> + * Logs a generic warning message about a missing feature.
> 
>> + * @param[in] avc pointer to an AVClass to be used as the av_log() context
> 
> :/
> 
> its either a struct that has a AVClass pointer as first element OR
> a **AVClass that is a pointer to a pointer to a AVClass.
> Both are the same but a pointer to an AVClass will not work.
> 
> Saying struct instead of pointer to a strict is safe as you cannot
> pass a struct by mistake, but pointer to pointer vs. pointer is not
> at all safe with void* the compiler cannot catch this ..

Ok. I just copied the text from av_log() instead.

>> + * @param[in] feature string containing the name of the missing feature
>> + * @param[in] want_sample indicates if samples are wanted which exhibit this fe
>                                                                                 ^^
> wh

oops. 80-char cut-off. fixed.

Thanks,
Justin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-add-a-generic-function-to-lavc-to-log-messages-about.patch
Type: text/x-patch
Size: 1949 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080719/d6547cdd/attachment.bin>