[FFmpeg-devel] [PATCH 2/4] Add functions which are specific to E-AC-3 decoding.
Sun Jul 20 13:40:35 CEST 2008
On Sun, Jul 20, 2008 at 01:26:11PM +0200, Michael Niedermayer wrote:
> On Sat, Jul 19, 2008 at 10:48:03PM -0400, Justin Ruggles wrote:
> A patch adding a FFT is self contained even if its unused, as a FFT has
> a well known definition, one knows what its input and output should be.
> I can review an incomplete decoder that implements only some parts of the
> decoding process, but its darn hard to review random broken out functions
> from a decoder with no comment and no code that uses them. Unless of course
> one knows the respective spec very well and fill the missing stuff in from
> knowledge, but i sadly do not know *AC3 that well. I know it
> approximately but i do not know all the fine details which makes reviewing
> such random code snippets rather hard.
A different way to say this is
That the function foo() and the code bar() that uses the function foo are
related and should be in the same patch. UNLESS there is a well documented
API between them that makes understanding the code possible just by
understanding the API and just foo() as well as just the API and bar().
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel