[FFmpeg-devel] [PATCH 1/4] add a generic function to lavc to log messages about missing features.
Sun Jul 20 22:34:45 CEST 2008
On Sat, Jul 19, 2008 at 08:31:52PM -0400, Justin Ruggles wrote:
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -3003,6 +3003,18 @@ int av_parse_video_frame_size(int *width_ptr, int *height_ptr, const char *str);
> + * Logs a generic warning message about a missing feature.
> + * @param[in] avc a pointer to an arbitrary struct of which the first field is
> + * a pointer to an AVClass struct.
> + * @param[in] feature string containing the name of the missing feature
> + * @param[in] want_sample indicates if samples are wanted which exhibit this feature
> + * If /p want_sample is non-zero, additional verbage will be added to the log
> + * message which tells the user how to report samples to the development
> + * mailing list.
All of this could use proper capitalization.
> --- a/libavcodec/utils.c
> +++ b/libavcodec/utils.c
> @@ -1488,3 +1488,15 @@ int av_parse_video_frame_rate(AVRational *frame_rate, const char *arg)
> +void av_log_missing_feature(void *avc, const char *feature, int want_sample)
> + av_log(avc, AV_LOG_WARNING, "%s not implemented. If you want to help, "
> + "update your FFmpeg version to the newest one from SVN. If the "
> + "problem still occurs, it means that your file has an extension "
"has an extension" sounds weird to me, it makes me think of filename
extension. "uses a feature" maybe?
> + "file to ftp://upload.mplayerhq.hu/incoming and contact the "
More information about the ffmpeg-devel