[FFmpeg-devel] [PATCH] Document opt.h:av_set_string functions

The Wanderer inverseparadox
Tue Jul 22 01:09:42 CEST 2008

Stefano Sabatini wrote:

> On date Monday 2008-07-21 06:41:09 -0400, The Wanderer encoded:

>> I understood what it meant; "In a similar way, prefixing a flag
>> with '-' causes it to be unset without affecting the other flags".
>> The less verbose form is understandable and less clunky IMO. This
>> should, however, be a separate 'sentence', split off by either a
>> period or a semicolon.
> Fixed with a semicolon.

One thing I forgot to mention: there should also be a comma after the
"similarly". (Strictly speaking it belongs there even in your original
form, but it would look awkward with a comma before the word as well.)

Also, as long as I'm glancing over the entire patch rather than just
someone else's quote of it: there should be a comma before the " or
NULL" in the return-value explanation.

Other than that, this looks good to me.

> PS Diego, I can't figure out what you mean with <complaint
> type="standard">,

For what it's worth, in a little time spent considering the question I
wasn't able to figure it out either.

       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.

More information about the ffmpeg-devel mailing list