[FFmpeg-devel] [PATCH] GET_RL_VLC can hide function parameters

Michael Niedermayer michaelni
Tue Jul 22 19:13:30 CEST 2008

On Tue, Jul 22, 2008 at 09:10:22AM -0700, Erik Hovland wrote:
> On Tue, Jul 22, 2008 at 04:24:49PM +0100, M?ns Rullg?rd wrote:
> > >> Wouldn't it be better to change the GET_RL_VLC macro to use names less
> > >> likely to clash?
> > >
> > > That is what the patch does. Is length too common as well?
> > 
> > I'd be inclined to say yes.
> Patch resubmitted with n changed to vlc_length.

vlc_length is semantically not correct, the variable does in general
not match the vlc length.

besides your patch mixes the var renaming with whitespace changes these
should be in seperate patches (the var renaming is not purely cosmetic)

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080722/a54d1072/attachment.pgp>

More information about the ffmpeg-devel mailing list