[FFmpeg-devel] [PATCH] movenc.c fix (Was: Can av_write_frame() modify pkt.data?)

Luca Abeni lucabe72
Wed Jul 23 09:17:32 CEST 2008

Hi Baptiste,

Baptiste Coudurier wrote:
>> I now see how your idea can simplify the code. Unfortunately, I got
>> sidetracked by some other issues, and I've not been able to test these
>> changes. I attach a patch, to show how the final result will look like,
>> but be aware that the patch is only compile-tested.
>> I am not sure I like the way I changed ff_isom_write_avcc()... I'll have
>> to think about it a little bit more.
>> I'll probably have a tested patch next week.
>> [...]
> Well at first sight, I'd say first patch not using ByteIOContext is simpler.

Sorry for the long silence about this issue... I've been busy with other
stuff. In the next days, I'll hopefully have more time for cleaning up
the patch and testing it. I'll probably post both the two patches (the one
using ByteIOContext, and the first one) so that people can decide which is

Just a question: which kind of tests should I run to be sure that my patches
do not break anything? Is "make test" enough, or there is some additional
test that I should run to test this code?


More information about the ffmpeg-devel mailing list