[FFmpeg-devel] [PATCH] movenc.c fix (Was: Can av_write_frame() modify pkt.data?)

Luca Abeni lucabe72
Thu Jul 24 10:09:25 CEST 2008


Luca Abeni wrote:
[...]
> I'll test h.264 (encoded through libavcodec + x264 with default options) in mp4,
> mov, matroska, and flv. Is this enough, or should I add some more tests?

Ok, here are the two possible patches (BTW, I just realized that the first one
looked smaller because it only fixed the mov muxer, and did not fix the flv and
mkv muxers...).

Both the patches pass "make test" without problems.
I created some mov, mp4, flv, and mkv files after applying the patches using the
following commands:
ffmpeg -i test.avi -vcodec libx264 -acodec copy test.mov
ffmpeg -i test.avi -vcodec libx264 -acodec copy test.mp4
ffmpeg -i test.avi -vcodec libx264 -acodec copy test.mkv
ffmpeg -i test.avi -vcodec libx264 -ar 44100 test.flv

The files generated with a patch applied are bit-identical to the files
generated without the patch, so I do not think that other tests are needed.
electric-fence did not find any problem after applying the patches.


			Luca
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: do_not_realloc_pkt_data.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080724/3615cf41/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: do_not_realloc_pkt_data_1.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080724/3615cf41/attachment.asc>



More information about the ffmpeg-devel mailing list