[FFmpeg-devel] [PATCH] movenc.c fix (Was: Can av_write_frame() modify pkt.data?)

Luca Abeni lucabe72
Thu Jul 24 10:15:34 CEST 2008

Hi Mike,

Mike Melanson wrote:
>> I'll test h.264 (encoded through libavcodec + x264 with default options) in mp4,
>> mov, matroska, and flv. Is this enough, or should I add some more tests?
> I'll test Apple QuickTime (on both Mac and Windows). Just give me the 
> right command lines.

See my previous email for the command lines. Anyway, I verified that the files
generated after applying the patches are identical to the files generated
without the patches, so I do not think that additional tests are needed.

> Then, if we can guarantee that the output will be 
> bit exact on all platforms, we can add the tests to FATE to ensure that 
> the functionality does not break.

I did not check if "make test" already tests these codec/muxer combinations
(h.264 in mp4, mov, mkv, and flv), but I think that it should... So, someone
should make sure that the "standard" regression tests already cover this case,
and then FATE could just run "make test".
Otherwise, you can use the command lines I mentioned in my previous email.


More information about the ffmpeg-devel mailing list